Posts

Some feedback:  

Rankings page gives me bad request and a plank page

I’ll be darn… I’m not sure if derpibooru would look like this when this site gets updated:  

Tag implication lists have no commas (on the Rails side there are commas) separating tags; combined with the decreased line height, it makes tag implication lists really messy and almost impossible to read.

When i click on “rankings” i arrive on a blank page with just “bad request” writed

@JP  
“false”: That would be because my finger slipped or something

@Marker  

I’m compiling changes to the API in a gist. At least the changes that affect my project. It’s public, so feel free to submit any revisions and use it in general.
 
That out of the way, random image seems to be broken. Old API returned just an ID of a random image, the new API returns basically the entire search results.
 
[Old API] /search.json?q=pinkie+pie&random_image=y  
[New API] /api/v1/json/search?q=pinkie+pie&random_image=y

I forgot that Elixir doesn’t sort dates according to their natural order, it sorts them by the order of the fields in the struct. Badges now appear in the correct order.

@byte[]  
When I first saw this I immediately became scared of a massive makeover and/or functionality changes. (not saying it’s always a bad thing, but I’ve seen many sites confuse changes and improvements are not synonymous). Glad that fear isn’t being realized and best of luck with it.

@DarthBarf  
@RicardW  
@Rainboom Dash
 
Tag slug problem is now fixed, I hope.

@RicardW  
It’s because of the parentheses
 
I already reported it in here and is being/has been looked into  
Also happens with ! and according to Darthbarf it also happens with apostrophes

@byte[]
 
Gotcha, so old API is under the current routes, and the new API is under /v1/.

@byte[]  
First, thanks for doing that so quickly! Also, thanks for resolving confusion about slugs vs tag ids that was in the previous API.
 
There might be an escaping problem with tag slugs in general in the new codebase. I looked in my local tag json directory and started testing anything which looked like it had a slug with a lot of escaping. Sure enough, there’s at least a problem with the url escaping of ‘(’ and ‘)’. It looks like this is a more general problem with tags though. If you go to https://philomena.derpibooru.org/1790981 and click on the bass guitar tag, you get a valid page, but if you click on you spin me round (like a record) (dead or alive) , you get a 404.

@Angius  
I’ll also throw in that the API docs are just a blob of HTML in the database and so they’re rendering the same. I haven’t updated the page yet.

@DarthBarf  
Yeah I’m trying to figure it out. It works in local development environments but not in production (the best kind of bug).
 
 
@Angius  
That’s the backwards-compatible fill for old API clients, as mentioned in the OP. The new API is exclusively under /api/v1/json (and /api/v1/rss for the watched feed). If you’re confused, please have a look at the router:
 
https://github.com/derpibooru/philomena/blob/5f9fe0cb98cee76c3b58b932f7103dea4975a859/lib/philomena_web/router.ex#L77-85

More Philomenas!

Not sure I understand the API changes…
 
Once the migration to Philomena is done, the old API stays under that /v1/ route. But do the new API routes stay the same as they are now? Because I can see that this has the exact same structure ans is on the exact same route as the old API was. The current API docs are also the same as the new API docs.
 
While we’re talking about the API, will the new backend (if not now then maybe in the future) have OAuth or something that’d let users using 3rd party apps vote on and fave pictures, comment, stuff like that?

@RicardW  
@byte[]
 
Here you go:
 
[example] GET /api/v1/json/tags/:slug
 
Navigation is done exclusively with the slug. The linked tags (in aliased_tags, etc.) are slugs.